refactor: remove unused merge checker - #688
Merged
Merged
Conversation
## Summary ### Why? SubmitQueue validation already crosses the Runway boundary, so the older in-process merge checker and its result entities have no callers and duplicate ownership of merge execution. ### What? Remove the mergechecker contract and implementations, delete the orphaned MergeResult and PushResult entities, and stop generating mergechecker mocks. ## Test Plan - ✅ `make gazelle` - ✅ `make test`
behinddwalls
marked this pull request as ready for review
September 8, 2026 03:52
behinddwalls
force-pushed
the
preetam/land-delete-mergechecker
branch
from
September 8, 2026 05:21
75b6513 to
7579304
Compare
This was referenced Sep 8, 2026
mnoah1
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
SubmitQueue validation already crosses the Runway boundary, so the older in-process merge checker and its result entities have no callers and duplicate ownership of merge execution.
What?
Remove the mergechecker contract and implementations, delete the orphaned MergeResult and PushResult entities, and stop generating mergechecker mocks.
Test Plan
make gazellemake testIssues